WIP: development experience updates/fixes #197
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @NeilHanlon and the rest of your teammates on |
NeilHanlon
commented
Jul 27, 2024
| @@ -109,7 +109,7 @@ local manifestYamlStream = function (value, indent_array_in_object=false, c_docu | |||
| image: image, | |||
| tag: tag, | |||
| }; | |||
| local istio_mode = if helm_mode then false else if utils.local_image then false else true; | |||
| local istio_mode = true; #if helm_mode then false else if utils.local_image then false else true; | |||
NeilHanlon
commented
Jul 27, 2024
| @@ -91,7 +91,7 @@ export default async function (opts) { | |||
| opts.issuerBaseURL.endsWith('.localhost/')) && | |||
| process.env['RESF_ENV'] | |||
| ) { | |||
| const kong = 'kong-proxy.kong.svc.cluster.local'; | |||
| const kong = 'istio-ingressgateway.istio-system.svc.cluster.local'; | |||
NeilHanlon
force-pushed
the
wip/dev-update
branch
from
9a98b09 to
f269935
Compare
NeilHanlon
force-pushed
the
wip/dev-update
branch
from
f269935 to
8aeedf3
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: NeilHanlon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
NeilHanlon
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Upgrade Temporal dependencies, improve Kubernetes pod configurations, and fix various bugs
What changed?