Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

small changes for setup scripts #170

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

JasonYangShadow
Copy link

I found that small changes were required for the setup script during my setup.

@resf-prow
Copy link
Contributor

resf-prow bot commented Feb 29, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: JasonYangShadow
Once this PR has been reviewed and has the lgtm label, please assign neilhanlon for approval by writing /assign @neilhanlon in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@resf-prow
Copy link
Contributor

resf-prow bot commented Feb 29, 2024

Hi @JasonYangShadow. Thanks for your PR.

I'm waiting for a rocky-linux member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@NeilHanlon
Copy link
Member

/ok-to-test

@NeilHanlon
Copy link
Member

Thank you for the PR @JasonYangShadow !

@JasonYangShadow
Copy link
Author

Thank you for the PR @JasonYangShadow !

still having issue on deploying the peridot locally, if you have pushed up your patches/fixes for peridot dev env, please feel free to DM me and I will test and update relative docs for peridot. Thanks! 👍🏽

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants