Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build RPM for peridot cli #169

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

build RPM for peridot cli #169

wants to merge 1 commit into from

Conversation

NeilHanlon
Copy link
Member

@NeilHanlon NeilHanlon commented Feb 29, 2024 •
edited
Loading

TL;DR

This PR introduces Bazel's rules_pkg and creates an RPM package for the Peridot CLI.

What changed?

  • Added rules_pkg dependency to the WORKSPACE
  • Modified BUILD.bazel to include pkg_attributes, pkg_files, and pkg_rpm rules
  • Set version information in the Go code using Bazel build variables

@NeilHanlon NeilHanlon marked this pull request as draft February 29, 2024 02:10
@resf-prow
Copy link
Contributor

resf-prow bot commented Feb 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: NeilHanlon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@resf-prow resf-prow bot added the approved label Feb 29, 2024
@NeilHanlon
Copy link
Member Author

todo: actually make semver releases.

@NeilHanlon NeilHanlon marked this pull request as ready for review March 11, 2024 16:32
@NeilHanlon
Copy link
Member Author

@mstg I was hoping I could use STABLE_BUILD_TAG here somehow, but I can't seem to figure how to pass this into the rules_pkg declaration.

Any thoughts?

@NeilHanlon Graphite App
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @NeilHanlon and the rest of your teammates on Graphite Graphite

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@NeilHanlon