Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: display build subtask timing properly regardless of location #161

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

NeilHanlon
Copy link
Member

No description provided.

@resf-prow resf-prow bot added the approved label Feb 21, 2024
@NeilHanlon
Copy link
Member Author

full disclosure i don't know how this new fangled javascript crap^Wstuff works and if I need to export that function, but.. i expect not based on Logic and Reason

@PlaidCat
Copy link

full disclosure i don't know how this new fangled javascript crap^Wstuff works and if I need to export that function, but.. i expect not based on Logic and Reason

I'm sufficiently happy with this.
For record when looking at duration on a kernel build it would say 6:24:00PM as the build time but the EastCoast is -5hr from UTC, the -360000 would then subtract another hour which is how the offset would arise.

/approve

@resf-prow
Copy link
Contributor

resf-prow bot commented Feb 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: NeilHanlon, PlaidCat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@NeilHanlon NeilHanlon force-pushed the fix/subtask-time-display branch from eb1bad7 to dc1a443 Compare March 28, 2024 21:26
@NeilHanlon NeilHanlon force-pushed the fix/subtask-time-display branch from dc1a443 to 6ab449e Compare March 28, 2024 21:30
@resf-prow
Copy link
Contributor

resf-prow bot commented Mar 28, 2024

@NeilHanlon: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-peridot-non-manual-build 6ab449e link true /test pull-peridot-non-manual-build
pull-peridot-build-impacted-frontend 6ab449e link true /test pull-peridot-build-impacted-frontend
pull-peridot-unit-test 6ab449e link true /test pull-peridot-unit-test
pull-peridot-gofmt-check 6ab449e link true /test pull-peridot-gofmt-check

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@NeilHanlon NeilHanlon marked this pull request as draft March 28, 2024 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants