Rockon pre & post-install summaries are inconsistent #2904 #2915
Conversation
Clarify header and mouse-over text in both associated tables. Normalise on column order (as per header) as per existing pre-install summary table. Includes: - Bug fix re some internal/external header-to-contents columns swapped. - Incidental bugfix re empty internal (to Rock-on) device cell entries.
TestingAn rpm was build and the handbrake rockon installed as it has share, env, dev, and facilitates the addition of docker entworks (rocknets) and labels (docker labels) to provide example screenshots of pre & post config submission summary screens thus: Pre install
Post install
Pre rocknetRocknets are a docker networks wrapper within the Web-UI.
Post rocknet
Pre container labelhttps://rockstor.com/docs/interface/overview.html#add-labels
Post container label
|
Custom optionWe have only one Rock-on that uses the custom config option, which is the openVPN rockon. There is an existing issue: "OpenVPN rock-on install wizard fails to show pre-install summary" #2913 Which prevents the creation of a pre install summay of this option variant. But the following is a post install summary demonstrating we have intended representation of the custom config option used:
|
phillxnet
deleted the
2904-Rockon-pre-&-post-install-summaries-are-inconsistent
branch
Clarify header and mouse-over text in both associated tables. Normalise on column order (as per header) as per existing pre-install summary table.
Includes:
Fixes #2904
Caveat
We have, post this proposal, one significant anomaly remaining.
In the first of the following summary dialog proofs (Pre install) we list for example
container-id:22against the share name in theExternal Reference / Configured valuecolumn. It would be more appropriate to indicate this container reference against the correspondingInternal Referencecolumn. And to of course resolve the id to the actual container name. However; this change is far deeper than is appropriate at this stage of our late testing phase development. And is to be addressed in due-course as we progress through itterative testing/stable phases. The main focus of this issue/PR set was to, with trivial template changes only, address confusing column switches and miss-representations only. In the same manner it would be nice to also surface container (by name) references in the final installed summaries. This, similarly, will be considered once we have addressed more pressing matters such as an update to our backbone dependencies.