Skip to content

Commit

Permalink
Swap order of newVolumes representation in summary table #2933
Browse files Browse the repository at this point in the history
The internal:external representation of volumes:shares in the summary
table showed at the end of the Add Storage to a Rock-On process was
the inverse to what it should have been (inverse of table headers).

This commit adjusts the Handlebars helper used to display the newly
added volume to swap the internal:external representations.
  • Loading branch information
FroggyFlox committed Dec 27, 2024
1 parent 812f1cf commit 4c4a876
Showing 1 changed file with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -1617,20 +1617,20 @@ RockonSettingsSummary = RockstorWizardPage.extend({
initHandlebarHelpers: function() {
Handlebars.registerHelper('display_newVolumes', function() {
// Display newly-defined shares and their corresponding mapping
// for confimation before submit in settings_summary_table.jst
// for confirmation before submit in settings_summary_table.jst
var html = '';
for (share in this.new_volumes) {
html += '<tr>';
html += '<td>Share</td>';
html += '<td>' + this.new_volumes[share] + '</td>';
html += '<td>' + share + '</td>';
html += '<td>' + this.new_volumes[share] + '</td>';
html += '</tr>';
}
return new Handlebars.SafeString(html);
});
Handlebars.registerHelper('display_newLabels', function() {
// Display newly-defined labels and their corresponding container
// for confimation before submit in settings_summary_table.jst
// for confirmation before submit in settings_summary_table.jst
var html = '';
for (new_label in this.new_labels) {
html += '<tr>';
Expand Down

0 comments on commit 4c4a876

Please sign in to comment.