Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ORC-2439] Remove GenerateWarnings option from Go client #124

Merged
merged 2 commits into from
Jul 31, 2023
Merged

[ORC-2439] Remove GenerateWarnings option from Go client #124

merged 2 commits into from
Jul 31, 2023

Conversation

karenl1
Copy link
Contributor

@karenl1 karenl1 commented Jul 31, 2023 •
edited
Loading

As titled, we are removing the "generate warnings" feature

@auto-assign auto-assign bot requested a review from pmenglund July 31, 2023 20:56
pmenglund
pmenglund approved these changes Jul 31, 2023
View reviewed changes
Copy link
Member

@pmenglund pmenglund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@pmenglund
Copy link
Member

you missed a spot:

vet: ./example_query_test.go:59:10: undefined: option.WithWarnings

@karenl1
Copy link
Contributor Author

karenl1 commented Jul 31, 2023

Thanks!

@karenl1 karenl1 merged commit 91b5fd0 into master Jul 31, 2023
3 checks passed
@karenl1 karenl1 deleted the kli_orc2439 branch July 31, 2023 21:06
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 678

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 3 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.08%) to 56.265%
Files with Coverage Reduction New Missed Lines %
option/query.go 1 0%
virtual_instances.go 2 73.28%
Totals Coverage Status
Change from base Build 675: 0.08%
Covered Lines: 1823
Relevant Lines: 3240
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmenglund pmenglund pmenglund approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@karenl1 @pmenglund @coveralls