Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changes for new async queries api #122

Merged
merged 5 commits into from
Jul 27, 2023
Merged

changes for new async queries api #122

merged 5 commits into from
Jul 27, 2023

Conversation

kristielim
Copy link
Contributor

No description provided.

@auto-assign auto-assign bot requested a review from pmenglund July 19, 2023 22:59
@kristielim kristielim requested a review from a team July 19, 2023 22:59
pmenglund
pmenglund requested changes Jul 24, 2023
View reviewed changes
option/query.go Outdated Show resolved Hide resolved
@kristielim kristielim force-pushed the kristie_async_queries_changes branch from 0f6f91a to 6c774a6 Compare July 27, 2023 02:35
pmenglund
pmenglund approved these changes Jul 27, 2023
View reviewed changes
Copy link
Member

@pmenglund pmenglund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 673

  • 0 of 10 (0.0%) changed or added relevant lines in 1 file are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.1%) to 56.188%
Changes Missing Coverage Covered Lines Changed/Added Lines %
option/query.go 0 10 0.0%
Files with Coverage Reduction New Missed Lines %
option/query.go 3 0%
Totals Coverage Status
Change from base Build 659: 0.1%
Covered Lines: 1825
Relevant Lines: 3248
💛 - Coveralls

@kristielim kristielim merged commit 8e797b6 into master Jul 27, 2023
3 checks passed
@kristielim kristielim deleted the kristie_async_queries_changes branch July 27, 2023 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmenglund pmenglund pmenglund approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kristielim @coveralls @pmenglund