Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(purger): Fix the purger loop #337

Merged
merged 1 commit into from
Oct 16, 2024
Merged

Conversation

jecaro
Copy link

@jecaro jecaro commented Sep 19, 2024

Right now the purger loops forever without waiting for purger_periodicity_millis between two runs. That's a bug. Additionally, when the purger is stopped, it waits the configured periodicity (10 minutes by default) before stopping. This is a real problem when one wants to gracefully shut down a DB.

This PR fixes it.

By toggling the precondition of wait_for, the purger now waits the right duration between two runs and shutdown on demand without waiting which is the intended behavior.

@dhruba
Copy link

dhruba commented Oct 5, 2024

Can you pl update our ICLA as listed in https://github.com/rockset/rocksdb-cloud/blob/master/CONTRIBUTING.md?

@jecaro jecaro mentioned this pull request Oct 6, 2024
Closed
@dhruba dhruba merged commit adb9f1a into rockset:master Oct 16, 2024
35 checks passed
@jecaro
Copy link
Author

jecaro commented Oct 17, 2024

Thanks @dhruba

Regarding the purger, that one #339 is even more important to merge short term.

The long-term would be to have a working implementation of the purger or completely remove the feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants