Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move some header files from cloud/ to include/rocksdb/cloud/ #304

Merged
merged 3 commits into from
Nov 18, 2023

Conversation

tudor
Copy link
Member

@tudor tudor commented Nov 18, 2023

So CloudFileSystemImpl et. al. can be extended from outside the tree

Test plan: it builds

Copy link

@igorcanadi igorcanadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would have preferred if you extended the implementation with a more targeted approach (i.e. make public the minimal thing that you need), but I don't want to slow you down.

@tudor tudor merged commit bb80d0c into master Nov 18, 2023
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants