Create an S3 client based on local storage #113
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, the unit tests are not able to run because we use actual S3 storage for tests. We want to mock the S3 storage using local storage so that unit test run faster.
In this PR, I created a class
TestS3ClientWrapper
which extendsAwsS3ClientWrapper
. Also, updaterun_tests.sh
to disable all networking for docker container to confirm that this test runs locally.Before my changes,
run_tests.sh
never completes. With my changes,run_tests.sh
completes all tests in 15 minutes. Breakdown as followed:db_test2
db_basoc_test
env_basic_test
cloud_manifest_test
db_cloud_test
db_test