Use virtual inheritance in FileSystem hierarchy.

rockset · Dec 21, 2023 · aa34eb2 · aa34eb2
1 parent 6700da7
commit aa34eb2
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 4 deletions.
diff --git a/include/rocksdb/cloud/cloud_file_system.h b/include/rocksdb/cloud/cloud_file_system.h
@@ -494,7 +494,7 @@ struct CloudManifestDelta {
 // NOTE: The AWS SDK must be initialized before the CloudFileSystem is
 // constructed, and remain active (Aws::ShutdownAPI() not called) as long as any
 // CloudFileSystem objects exist.
-class CloudFileSystem : public FileSystem {
+class CloudFileSystem : public virtual FileSystem {
  protected:
   CloudFileSystemOptions cloud_fs_options;
   std::shared_ptr<FileSystem> base_fs_;  // The underlying file system

diff --git a/include/rocksdb/cloud/cloud_file_system_impl.h b/include/rocksdb/cloud/cloud_file_system_impl.h
@@ -22,7 +22,7 @@ class CloudFileDeletionScheduler;
 //
 // The Cloud file system
 //
-class CloudFileSystemImpl : public CloudFileSystem {
+class CloudFileSystemImpl : public virtual CloudFileSystem {
   friend class CloudFileSystem;
 
  public:
@@ -236,7 +236,6 @@ class CloudFileSystemImpl : public CloudFileSystem {
         "CloudFileSystemImpl::IsDirectory() not supported.");
   }
 
-
   IOStatus Poll(std::vector<void*>& io_handles,
                 size_t /*min_completions*/) override {
     for (auto* handle : io_handles) {

diff --git a/include/rocksdb/file_system.h b/include/rocksdb/file_system.h
@@ -1380,7 +1380,7 @@ class FSDirectory {
 // An implementation of Env that forwards all calls to another Env.
 // May be useful to clients who wish to override just part of the
 // functionality of another Env.
-class FileSystemWrapper : public FileSystem {
+class FileSystemWrapper : public virtual FileSystem {
  public:
   // Initialize an EnvWrapper that delegates all calls to *t
   explicit FileSystemWrapper(const std::shared_ptr<FileSystem>& t);