Add option to create new instances of loaded libraries #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m0rsch1
reviewed
Nov 15, 2024
| @@ -133,6 +133,8 @@ namespace lib_manager { | |||
| string name = _lib->getLibName(); | |||
|
|
|||
| newLib.destroy = 0; | |||
| newLib.create = 0; | |||
There was a problem hiding this comment.
Instead of using 0 here, it would be better to use one of the following:
- (void *)0
- NULL
- nullptr
| LibInterface* LibManager::getNewInstance(const string &libName) { | ||
| if(libMap.find(libName) == libMap.end()) { | ||
| #ifdef DEBUF | ||
| fprintf(stderr, "LibManager: could not find \"%s\"\n", libName.c_str()); |
There was a problem hiding this comment.
Use std::cerr here. We are in C++ not in C.
| return 0; | ||
| } | ||
| libStruct *theLib = &(libMap[libName]); | ||
| // todo: clear how to deal with the use count in this case |
There was a problem hiding this comment.
If you would use shared pointers, you would not need to reference count yourself.
| @@ -45,6 +45,8 @@ namespace lib_manager { | |||
| struct libStruct { | |||
| LibInterface *libInterface; | |||
| destroyLib *destroy; | |||
| createLib *create; | |||
There was a problem hiding this comment.
I would recommend using safer/smart pointers instead of raw ones.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.