Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rotate dvl velocity to body frame #13

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

joaobrittoneto
Copy link
Contributor

Aggregate angular velocity.

Aggregate angular velocity.
@joaobrittoneto
Copy link
Contributor Author

@saarnold, @doudou,
Any comment here?
May I merge this PR?

@saarnold
Copy link
Member

Why not using the VelocityProvider from uwv_kalman_filters instead?
You don't align the streams and return in the update hook before reading all samples out. So you could end up applying old orientation or angular velocity measurements to the velocity measurements.

@joaobrittoneto
Copy link
Contributor Author

My concern with the VelocityProvider is that it makes use of a model internally. The purpose of this component is the feed the model identification with velocities, and doing it with velocity provided by an internal model may be questionable.

So you could end up applying old orientation or angular velocity measurements to the velocity measurements.

I was expecting the sampling rate of the orientation and angular velocity to be way higher than the dvl. But I agree with you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants