Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to newer nixpkgs and flakes #1

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

MMesch
Copy link

@MMesch MMesch commented Aug 16, 2023

No description provided.

@robwhitaker
Copy link
Owner

Thanks for the PR @MMesch! Sorry for taking so long to notice it; I didn't see any notification for it in my email. I actually just came back to this repo thinking I should update it since I started using Taskwarrior again, and there was a PR waiting doing just that!

Just a couple notes before I merge it:

  1. Would you mind updating the flake.nix description to something non-default? The synopsis in the cabal file or the repo description is fine.
  2. Is there a reason to bring in hls-splice-plugin and hls-eval-plugin in the devShell? Are they not brought along inherently with haskell-language-server? Even if not, I don't think there is any code in this project that benefits from the extra plugins so I'd rather not include them.

Other than that, it all looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants