Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, this PR wants to help with #31.
I tried to add a C checksum function but so far I probably have something bad in my setup as I don't see any speed difference (I probably have a bottleneck somewhere in my Linux as I run my tests locally maybe it put pressure on the local tap interface?).
Here are my tests (I used https://github.com/palainp/solo5memory as html unikernel):
All rates are so similar and that leads me to think about another bottleneck in my setup :(
This PR also brings a
.S
function that should be faster but I currently have issues embedding it into a c file and dune doesn't seem to support assembly stub files.I still haven't done anything for the big endian version as I'm not sure that using C bindings is of much help :)