Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat] Add new method to disconnect to redis #47

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

[feat] Add new method to disconnect to redis #47

wants to merge 7 commits into from

Conversation

lucas-m-ribeiro
Copy link

  • Hello @nottyo, I would like to contribute to this pull request by implementing a new keyword for the redis library. This implementation will be responsible for safely disconnecting the database. This implementation resolves the reported issue No disconnect keyword #32 (comment)
    I hope that this contribution adds positively to the project and that everyone can benefit. I would like feedback on the implementation. I am available to answer any possible questions.

leonpros
leonpros suggested changes Oct 28, 2024
View reviewed changes
Copy link

@leonpros leonpros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change method name and keyword

RedisLibrary/RedisLibraryKeywords.py Outdated Show resolved Hide resolved
leonpros
leonpros approved these changes Oct 28, 2024
View reviewed changes
Copy link

@leonpros leonpros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leonpros leonpros leonpros approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lucas-m-ribeiro @leonpros