Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No disconnect keyword #32

Open
leonpros opened this issue Jan 18, 2022 · 3 comments
Open

No disconnect keyword #32

leonpros opened this issue Jan 18, 2022 · 3 comments

Comments

@leonpros
Copy link

running many tests when each test creates a connection will eventually cause connection error.
the workaround is creating a single connection at the beginning of suite and leaving connection alive when test ends (will be closed after timeout of keep-alive).
this is not a good practice.

A disconnect keyword is required.

@lucas-m-ribeiro
Copy link

@leonpros Hi, how are you? Im implemented a PR with solution for disconnect database!

@lucas-m-ribeiro
Copy link

Hi @leonpros how are you? A some days ago I'm contributed with a PR to implement a new keyword to disconnect from redis. I'm mentioned @nottyo but I think that he is no more maintainer on this repo. You approved my changes, can you help me with other maintainer to review and approve my PR for generate new release?
Thanks for help

@leonpros
Copy link
Author

leonpros commented Nov 4, 2024

Hi @leonpros how are you? A some days ago I'm contributed with a PR to implement a new keyword to disconnect from redis. I'm mentioned @nottyo but I think that he is no more maintainer on this repo. You approved my changes, can you help me with other maintainer to review and approve my PR for generate new release? Thanks for help

Hi,

I'm not sure I can be of any help.
I do not have privileges on the proect and no relations to the mainteiners

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants