Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run tests on nightly with cargo-careful #100

Merged
merged 1 commit into from
Sep 28, 2023
Merged

Run tests on nightly with cargo-careful #100

merged 1 commit into from
Sep 28, 2023

Conversation

robo9k
Copy link
Owner

@robo9k robo9k commented Sep 27, 2023

This should, in theory, uncover more test problems than regular cargo test.

@robo9k
Copy link
Owner Author

robo9k commented Sep 27, 2023

Testing this locally, the combination of cargo-llvm-cov and then cargo-careful fails like in GHA. Running only cargo-careful works locally, regardless of the nightly version.

Filed taiki-e/cargo-llvm-cov#318

@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (3385e50) 42.27% compared to head (80e0190) 42.27%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #100   +/-   ##
=======================================
  Coverage   42.27%   42.27%           
=======================================
  Files           2        2           
  Lines         511      511           
  Branches      511      511           
=======================================
  Hits          216      216           
  Misses        289      289           
  Partials        6        6           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@robo9k
Copy link
Owner Author

robo9k commented Sep 28, 2023

Separate jobs for cargo-llvm-cov and cargo-careful as per linked issue:

Yeah, you have to use two separate CI jobs at this time.

@robo9k robo9k merged commit bd0cf22 into main Sep 28, 2023
13 of 14 checks passed
@robo9k robo9k deleted the cargo-careful branch September 28, 2023 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant