Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto dot #237

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Auto dot #237

wants to merge 3 commits into from

Conversation

GBR-613
Copy link

@GBR-613 GBR-613 commented Mar 6, 2024

Fixing issue #230

@robhagemans
Copy link
Owner

Thanks for fixing this bug! I found a simpler approach (the main problem was that from_line was calculated but then ignored, along with the initial setting of last_stored to None).

I've taken your commit fixing PyLint warnings and will merge all or part of it - some things PyLint complains about are conscious coding style choices, but not all of it.

@GBR-613
Copy link
Author

GBR-613 commented Mar 10, 2024

@robhagemans I remember I tried to implement "from_line based" approach and found a scenario when the behavior was like I would expect yet different from GWBASIC, and ended up with this one.
Unfortunately I don't remember that scenario. If I will succeed to reproduce I will report.

@robhagemans
Copy link
Owner

Thanks! Let me know if you find the scenario. One thing I noticed was that after the change , AUTO . if used on an empty program buffer would start at line number 10, whereas this should be line number 0. The change in initial value for last_stored deals with this, without AFAICS undesired side effects.

Actually I still need to create a test for the latter scenario.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants