Adding support for custom domains #12
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been seeing errors when connecting to Salesforce for 'client identifier invalid'. The errors happen sporadically, so it's not something on our end, it's Salesforce. I found some posts that recommend using your domain instead of 'login.salesforce.com'. I updated the repo to allow that.
In addition, for some salesforce instances like Gov Cloud instances, you can't actually login with 'login.salesforce.com', you HAVE to use the custom domain. This allows support for that.
I allowed use of 'sandbox' OR 'domain', but not both. Using both raises a ValueError since it would be difficult to judge what the user intended. I added tests for these scenarios, and all the other tests pass.