Merge pull request #52 from robcresswell/chore/add-failing-click-test

fix: apply listeners correctly in functional component
robcresswell · Sep 10, 2019 · cafe4cf · cafe4cf
2 parents 2420f2f + 3c6da0c
commit cafe4cf
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 1 deletion.
diff --git a/__tests__/icon.js b/__tests__/icon.js
@@ -49,4 +49,23 @@ describe('Icon', () => {
   it('renders an icon', () => {
     expect(icon).toMatchSnapshot();
   });
+
+  it('listens to a click event', () => {
+    const clickListener = jest.fn()
+    const iconWithEvent = mount({
+      name: 'IconWithEvent',
+      components: { AndroidIcon },
+      template: `
+        <AndroidIcon
+          @click="clickListener"
+        />
+      `,
+      methods: {
+        clickListener,
+      },
+    })
+
+    iconWithEvent.trigger('click')
+    expect(clickListener).toBeCalled()
+  });
 });
diff --git a/template.mst b/template.mst
@@ -5,7 +5,7 @@
         :class="[data.class, data.staticClass]"
         class="material-design-icon <%title%>-icon"
         role="img"
-        @click="listeners.click ? listeners.click : () => true">
+        v-on="listeners">
     <svg :fill="props.fillColor"
          class="material-design-icon__svg"
          :width="props.size"