Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed external phase delay issue described in … #128

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

robclewley
Copy link
Owner

@robclewley robclewley commented Sep 17, 2017

VODE was looking ahead by one time sample when preparing next time step's external inputs for use in the RHS function. This partly fixes the primary issue described here:
https://sourceforge.net/p/pydstool/discussion/472291/thread/e55d28a2/

@robclewley
Copy link
Owner Author

robclewley commented Sep 17, 2017

Not ready for merge!

There is more exploration needed to completely remove the error between using an external input sampled from sin(t) and the original forcing function, sin(t). The C-based integrators seem to be correct, and so is VODE when sin(t) is used directly, so there's something wrong with the computation of input values on time steps for the VODE Generator. Euler should also be checked.

Then, the regression tests for external inputs will need adjusting (currently failing in CI)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant