Docblock psudo methods can be inherited via @mixin

Fixes vimeo#3556
robchett · Nov 8, 2023 · 21845aa · 21845aa
1 parent b775d29
commit 21845aa
Show file tree

Hide file tree

Showing 2 changed files with 28 additions and 0 deletions.
diff --git a/src/Psalm/Internal/Analyzer/Statements/Expression/Call/Method/MissingMethodCallHandler.php b/src/Psalm/Internal/Analyzer/Statements/Expression/Call/Method/MissingMethodCallHandler.php
@@ -435,6 +435,12 @@ private static function findPseudoMethodAndClassStorages(
         }
 
         $ancestors = $static_class_storage->class_implements;
+        foreach ($static_class_storage->namedMixins as $namedObject) {
+            $type = $namedObject->value;
+            if ($type) {
+                $ancestors[$type] = true;
+            }
+        }
 
         foreach ($ancestors as $fq_class_name => $_) {
             $class_storage = $codebase->classlikes->getStorageFor($fq_class_name);

diff --git a/tests/MixinAnnotationTest.php b/tests/MixinAnnotationTest.php
@@ -596,6 +596,28 @@ class FooModel extends Model {}
                     '$g' => 'list<FooModel>',
                 ],
             ],
+            'mixinInheritMagicMethods' => [
+                'code' => '<?php
+                    /**
+                     * @method $this active()
+                     */
+                    class A {
+                        public function __call(string $name, array $arguments) {}
+                    }
+
+                    /**
+                     * @mixin A
+                     */
+                    class B {
+                        public function __call(string $name, array $arguments) {}
+                    }
+
+                    $b = new B;
+                    $c = $b->active();',
+                'assertions' => [
+                    '$c' => 'B&static',
+                ],
+            ],
         ];
     }