Issue checkstyle#440: resolves AvoidConstantAsFirstOperandInCondition…

…Check
rnveach · Jan 27, 2023 · 60a74c3 · 60a74c3
1 parent 84f1b61
commit 60a74c3
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/config/CheckConfigurationPropertiesDialog.java b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/config/CheckConfigurationPropertiesDialog.java
@@ -317,14 +317,14 @@ protected void okPressed() {
  0);
  int result = dialog.open();
 
- if (0 == result) {
+ if (result == 0) {
  ResolvablePropertiesDialog propsDialog = new ResolvablePropertiesDialog(getShell(),
  mCheckConfig);
  propsDialog.open();
  return;
- } else if (1 == result) {
+ } else if (result == 1) {
  super.okPressed();
- } else if (2 == result) {
+ } else if (result == 2) {
  return;
  }
  } else {

diff --git a/...ipsecs.ui/src/net/sf/eclipsecs/ui/config/configtypes/ExternalFileConfigurationEditor.java b/...ipsecs.ui/src/net/sf/eclipsecs/ui/config/configtypes/ExternalFileConfigurationEditor.java
@@ -142,7 +142,7 @@ public void widgetSelected(SelectionEvent e) {
  fileDialog.setFileName(mLocation.getText());
 
  String file = fileDialog.open();
- if (null != file) {
+ if (file != null) {
  mLocation.setText(file);
  }
  }

diff --git a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/config/widgets/ConfigPropertyWidgetFile.java b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/config/widgets/ConfigPropertyWidgetFile.java
@@ -100,7 +100,7 @@ public void widgetSelected(SelectionEvent e) {
  fileDialog.setFileName(mTextWidget.getText());
 
  String file = fileDialog.open();
- if (null != file) {
+ if (file != null) {
  mTextWidget.setText(file);
  }
  }