Update FFI API with key certification and signature customization functions. #2270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2270 +/- ##
==========================================
+ Coverage 84.02% 84.21% +0.19%
==========================================
Files 114 114
Lines 23062 23324 +262
==========================================
+ Hits 19377 19642 +265
+ Misses 3685 3682 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ni4
force-pushed
the
ni4-1085-add-key-certify
branch
from
a1c65ea
to
1fc6ff0
Compare
ni4
force-pushed
the
ni4-1085-add-key-certify
branch
from
1fc6ff0
to
ceeeeb8
Compare
desvxx
reviewed
Sep 17, 2024
desvxx
reviewed
Sep 17, 2024
desvxx
approved these changes
Sep 17, 2024
ni4
force-pushed
the
ni4-1085-add-key-certify
branch
from
ceeeeb8
to
736dc4c
Compare
ni4
force-pushed
the
ni4-1085-add-key-certify
branch
from
736dc4c
to
7b217be
Compare
ni4
force-pushed
the
ni4-1085-add-key-certify
branch
from
7b217be
to
16b05a8
Compare
|
Let's merge it, having 2 approvals and green CI. Thanks all! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR update FFI API with a number of functions for signature customization or information retrieval. Also it adds functions to create self-certifications and other key certification creation.
Fixes #1085