Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve key updating performance. #2256

Merged
merged 4 commits into from
Aug 26, 2024
Merged

Improve key updating performance. #2256

merged 4 commits into from
Aug 26, 2024

Conversation

ni4
Copy link
Contributor

@ni4 ni4 commented Jul 31, 2024

...and remove some amount of old, not more needed, code.

@ni4 ni4 force-pushed the ni4-simplify-key-updating branch from 537862d to 8e67f1d Compare July 31, 2024 16:46
Copy link

codecov bot commented Jul 31, 2024

Codecov Report

Attention: Patch coverage is 94.59459% with 2 lines in your changes missing coverage. Please review.

Project coverage is 83.89%. Comparing base (45e3392) to head (688780a).
Report is 4 commits behind head on main.

Files Patch % Lines
src/lib/pgp-key.cpp 94.59% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2256      +/-   ##
==========================================
+ Coverage   83.77%   83.89%   +0.11%     
==========================================
  Files         113      113              
  Lines       23203    23092     -111     
==========================================
- Hits        19439    19373      -66     
+ Misses       3764     3719      -45     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ni4 ni4 force-pushed the ni4-simplify-key-updating branch 2 times, most recently from 98115bb to 347de0c Compare August 1, 2024 09:16
@ni4 ni4 force-pushed the ni4-simplify-key-updating branch from 347de0c to 15d07df Compare August 22, 2024 15:34
@ni4 ni4 force-pushed the ni4-simplify-key-updating branch from 15d07df to 688780a Compare August 24, 2024 09:11
@ni4 ni4 marked this pull request as ready for review August 24, 2024 14:04
@ni4
Copy link
Contributor Author

ni4 commented Aug 26, 2024

Merging as there are two approvals. Thanks!

@ni4 ni4 merged commit 08e277d into main Aug 26, 2024
123 checks passed
@ni4 ni4 deleted the ni4-simplify-key-updating branch August 26, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants