Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libsexpp updated to 0.8.8 #2242

Merged
merged 3 commits into from
Jun 24, 2024
Merged

libsexpp updated to 0.8.8 #2242

merged 3 commits into from
Jun 24, 2024

Conversation

maxirmx
Copy link
Member

@maxirmx maxirmx commented Jun 3, 2024

Closes #2241

Copy link

codecov bot commented Jun 3, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 83.58%. Comparing base (657b188) to head (e0790a2).

Files Patch % Lines
src/librekey/key_store_g10.cpp 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2242      +/-   ##
==========================================
- Coverage   83.58%   83.58%   -0.01%     
==========================================
  Files         107      107              
  Lines       23174    23167       -7     
==========================================
- Hits        19371    19364       -7     
  Misses       3803     3803              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maxirmx maxirmx changed the title libsexpp updated to 0.9.0 libsexpp updated to 0.8.8 Jun 6, 2024
@maxirmx maxirmx force-pushed the maxirmx-libsexpp-update branch 2 times, most recently from ae69bf5 to 8fe8b89 Compare June 17, 2024 07:05
@ni4
Copy link
Contributor

ni4 commented Jun 17, 2024

@maxirmx JFYI, CI is now broken due to Botan head issue. I'm fixing it via the PR #2240

@maxirmx
Copy link
Member Author

maxirmx commented Jun 17, 2024

@maxirmx JFYI, CI is now broken due to Botan head issue. I'm fixing it via the PR #2240

Thank you
I struggling with python upgrade on MacOs/ I guess it is something different

@maxirmx maxirmx force-pushed the maxirmx-libsexpp-update branch 2 times, most recently from cb0b04f to c02e22c Compare June 17, 2024 20:01
@maxirmx maxirmx marked this pull request as ready for review June 17, 2024 21:18
@maflcko
Copy link

maflcko commented Jun 18, 2024

lgtm.

There is still https://github.com/rnpgp/rnp/blame/main/src/lib/types.h#L75

I guess one needs to include the sexp.h header before the types.h header?

@maxirmx maxirmx force-pushed the maxirmx-libsexpp-update branch 4 times, most recently from 133ebf8 to 817caea Compare June 19, 2024 17:33
Copy link
Contributor

@ronaldtse ronaldtse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maxirmx thanks, please merge when ready.

@maxirmx
Copy link
Member Author

maxirmx commented Jun 20, 2024

@ni4 , I think we shall merge it on top of #2240

@ni4
Copy link
Contributor

ni4 commented Jun 20, 2024

@maxirmx Yeah, like a bunch of other PRs :) Waiting for the second approval cc @ronaldtse

@ni4
Copy link
Contributor

ni4 commented Jun 24, 2024

@maxirmx Now PR with CI fixes is merged, could you please rebase this? Or I can do that as well.

@ni4
Copy link
Contributor

ni4 commented Jun 24, 2024

@maxirmx ....and one more thing - macos-11 runner deprecation at the end of June, with scheduled failures at Jun, 24 :) fb22831

@maxirmx
Copy link
Member Author

maxirmx commented Jun 24, 2024

@maxirmx ....and one more thing - macos-11 runner deprecation at the end of June, with scheduled failures at Jun, 24 :) fb22831

Does it mean that it shall not ve merged ?

@maxirmx maxirmx merged commit 20419f7 into main Jun 24, 2024
126 of 128 checks passed
@maxirmx maxirmx deleted the maxirmx-libsexpp-update branch June 24, 2024 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sexpp: clang-18: error: implicit instantiation of undefined template 'std::char_traits<unsigned char>'
5 participants