Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor pgp_mpi_t to pgp::mpi. #2239

Merged
merged 2 commits into from
Jun 25, 2024
Merged

Refactor pgp_mpi_t to pgp::mpi. #2239

merged 2 commits into from
Jun 25, 2024

Conversation

ni4
Copy link
Contributor

@ni4 ni4 commented May 28, 2024

No description provided.

Copy link

codecov bot commented May 28, 2024

Codecov Report

Attention: Patch coverage is 95.62842% with 8 lines in your changes missing coverage. Please review.

Project coverage is 83.59%. Comparing base (657b188) to head (df64145).

Files Patch % Lines
src/librepgp/stream-dump.cpp 86.95% 6 Missing ⚠️
src/lib/crypto/rsa.cpp 80.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2239   +/-   ##
=======================================
  Coverage   83.58%   83.59%           
=======================================
  Files         107      107           
  Lines       23174    23169    -5     
=======================================
- Hits        19371    19367    -4     
+ Misses       3803     3802    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ni4 ni4 marked this pull request as ready for review June 24, 2024 10:44
Copy link
Member

@maxirmx maxirmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ronaldtse
Copy link
Contributor

Thank you @ni4 !

@ronaldtse ronaldtse merged commit 59a4e92 into main Jun 25, 2024
128 checks passed
@ronaldtse ronaldtse deleted the ni4-refactor-pgp_mpi_t branch June 25, 2024 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants