Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up msbuild workflow #9

Merged
merged 1 commit into from
Aug 15, 2024
Merged

Clean up msbuild workflow #9

merged 1 commit into from
Aug 15, 2024

Conversation

HexDecimal
Copy link
Collaborator

@HexDecimal HexDecimal commented Aug 15, 2024

Updated and formatted nearly everything. All workflow warnings have been fixed.

Only downloads the libtcod files needed for the current matrix.platform.

Uploads fully packaged releases which you can fetch from the actions page. This includes running Incursion -compile on debug builds and replacing the binaries with release versions. These are publicly playable builds for x86 and x64.

The packaged releases might be tar-bombs at the moment. Easy to fix if that's a problem, but will make the workflow more complex.

Closes #6

Apply a standard format to the entire file

Update setup-msbuild action to v2

Compile and upload mod file during debug build

Upload fully packaged releases
@HexDecimal
Copy link
Collaborator Author

I have have been overzealous with packaging. Should docs be included in distributions?

@rmtew rmtew merged commit 3251c4e into rmtew:master Aug 15, 2024
6 checks passed
@rmtew
Copy link
Owner

rmtew commented Aug 15, 2024

Not the docs in the repo.

@HexDecimal
Copy link
Collaborator Author

HexDecimal commented Aug 15, 2024

You've should've let me remove them before merging then. Since the PR is merged I'll leave it to you. You can edit the name: Package Incursion step to decide what gets packaged.

@HexDecimal
Copy link
Collaborator Author

If you wanted non-devs to try the x64 version then consider doing a manual release on GitHub and moving the release artifacts to there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Continous integration
2 participants