Ensure tracked generated files are rebuilt in tests #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm having a hard time verifying this. Your idea of deleting the files is probably easier to do. |
|
Reference to the commit conversion because I don't want to have trouble hunting it down later: 40c235d |
|
I am pretty sure I always hit the rebuild hotkey just to be sure (ctrl+shift_b) and it does not rebuild these files because it does not change the gnerated output in any way by doing that rebuild. |
|
For now I'm going to take the fact that the x64 builds didn't fail as proof that this method doesn't work. |
Current builds were assuming that generated files are already built based on their timestamps, which prevents testing newly updated generated files. This manually deletes the generated files to be tested.
HexDecimal
changed the title
HexDecimal
changed the title
|
Files are now deleted by the CI before building, only (Debug, Win32) is able to actually build these files as usual. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Normal builds would assume that generated files are already built based on their timestamps which prevents testing newly updated generated files.
/t:rebuildshould always do a clean rebuild.