Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

basic bzlmod support #61

Closed
wants to merge 5 commits into from
Closed

basic bzlmod support #61

wants to merge 5 commits into from

Conversation

malt3
Copy link
Contributor

@malt3 malt3 commented Aug 11, 2023

This is the first step towards enabling bzlmod support.
On this branch, you can add the following to your .bazelrc (or add it to your bazel build flags):

.bazelrc

common --enable_bzlmod

The project should build (bazel build //...) and all tests should pass (bazel test //...).
Also, when removing the --enable_bzlmod, the project should fall back to using the WORKSPACE file and everything should still build correctly.

TODOs (maybe for future PRs):

  • decide how to handle go-rpmutils: I had issues with using the replace directive in the go.mod so I forked your fork and changed the name of the module. It would be great if we either just decide to use a renamed fork or upstream the changes
  • Create module extension for rpm rules (rpm rules are currently repo rules that create new repositories. This works differently under bzlmod).
  • test if bazeldnf rules work in other bzlmod enabled projects
  • prepare submission to BCR
  • add CI tests that run tests with and without bzlmod

Allows "bazel build //..." to work
renaming rpmutils is required for bzlmod since rules_go under bzlmod does not yet support replace directives
This is the first stage of enabling bzlmod support.
@msanft
Copy link

msanft commented Nov 23, 2023

Hey @rmohr,

Could you take a look at this soon? bzlmod support would be awesome!

@manuelnaranjo manuelnaranjo mentioned this pull request Dec 22, 2023
@rmohr
Copy link
Owner

rmohr commented Jul 11, 2024

@manuelnaranjo took over the work and landed the first parts of adding bzlmod support in #73.

@rmohr
Copy link
Owner

rmohr commented Oct 7, 2024

Finally there with #77

@rmohr rmohr closed this Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants