Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make sure version entity name is valid #39

Merged
merged 2 commits into from
Oct 16, 2023

Conversation

dckiller51
Copy link
Contributor

Fixes the error if your host has capital letters and or a "-".

Fixes the error if your host has capital letters and or a "-".
@rmoesbergen rmoesbergen changed the title Update presence-detector.py fix: make sure version entity name is valid Oct 16, 2023
@rmoesbergen
Copy link
Owner

@dckiller51 thanks! Can you please fix the pylint error, and remove the version update (as 2.0.2 has not been released yet).
Does this fix the error you reported in #33 ?

Copy link
Owner

@rmoesbergen rmoesbergen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pylint error (line too long). please use 'black' to format the file.

@dckiller51
Copy link
Contributor Author

@dckiller51 thanks! Can you please fix the pylint error, and remove the version update (as 2.0.2 has not been released yet). Does this fix the error you reported in #33 ?

Yes that's right.

@rmoesbergen rmoesbergen merged commit 9b5aac3 into rmoesbergen:main Oct 16, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants