Skip to content

Commit

Permalink
v0.4.1 update - fixed typos
Browse files Browse the repository at this point in the history
  • Loading branch information
rmlibre committed Dec 15, 2019
1 parent c77e864 commit 70129f7
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 7 deletions.
7 changes: 6 additions & 1 deletion CHANGES.md
Original file line number Diff line number Diff line change
@@ -1,10 +1,15 @@
# Changes for version 0.4.0
# Changes for version 0.4.1
## Known Issues
- Because of Debian [bug #930665](https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=930665), and related GnuPG [bug #T4393](https://dev.gnupg.org/T4393), importing keys from the default keyserver [keys.openpgp.org](https://keys.openpgp.org/) doesn't work automatically on all systems. Not without email confirmation, at least. That's because the keyserver will not publish uid information attached to a key before a user confirms access to the email address assigned to the uploaded key. And, because GnuPG folks are still holding up the merging, and back-porting, of patches that would allow GnuPG to automatically handle keys without uids gracefully. This effects the `network_import()` method specifically, but also the `text_import()` and `file_import()` methods, if they happen to be passed a key or filename argument which refers to a key without uid information. The gpg2 binary in this package can be replaced manually if a user's system has access to a patched version.
- This program may only be reliably compatible with keys that are also created with this program. That's because our terminal parsing is reliant on specific metadata to be similar across all encountered keys. It seems most keys have successfully been parsed with recent updates, though more testing is needed.
- Currently, the package is part synchronous, and part asynchronous. This is not ideal, so a decision has to be made: either to stay mixed style, or choose one consistent style.
- We're still in unstable and have to build out our test suite. Contributions welcome.
## Minor Changes
- Fixed typos in `tiny_gnupg.py`.


# Changes for version 0.4.0
## Minor Changes
- Added keywords to `setup.py`
- Added copyright notice to LICENSE file.
- Code cleanups.
Expand Down
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
setup(
name="tiny_gnupg",
license="GPLv3",
version="0.4.0",
version="0.4.1",
description=description,
long_description=long_description,
url="https://github.com/rmlibre/tiny_gnupg",
Expand Down
2 changes: 1 addition & 1 deletion tiny_gnupg/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,6 @@
# All rights reserved.
#

__version__ = "0.4.0"
__version__ = "0.4.1"

from .tiny_gnupg import GnuPG, __all__
8 changes: 4 additions & 4 deletions tiny_gnupg/tiny_gnupg.py
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ def format_homedir(self, path=HOME_PATH):
def set_home_permissions(self, home):
try:
home = str(Path(home).absolute())
command = ["chmod", "-R", "700", self.home]
command = ["chmod", "-R", "700", home]
return self.read_output(command)
except:
print(f"Invalid permission to modify home folder: {home}")
Expand Down Expand Up @@ -299,9 +299,9 @@ def verify(self, message=""):

def raw_list_keys(self, uid=""):
if uid:
command = self.command(f"--list-keys", uid)
command = self.command("--list-keys", uid)
else:
command = self.command(f"--list-keys")
command = self.command("--list-keys")
return self.read_output(command)

def format_list_keys(self, raw_list_keys_terminal_output):
Expand Down Expand Up @@ -431,7 +431,7 @@ def text_export(self, uid="", *, secret=False):
inputs = self.encode_inputs(self.passphrase)
return self.read_output(command, inputs)
elif secret == False:
command = self.command("-a", f"--export", uid)
command = self.command("-a", "--export", uid)
return self.read_output(command)
else:
raise ValueError(f"secret != boolean, {type(secret)} given")

0 comments on commit 70129f7

Please sign in to comment.