Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for Translation Strings as Keys #82

Closed
wants to merge 9 commits into from

Conversation

alwintom
Copy link

@alwintom alwintom commented May 4, 2020

This PR will add larave's Translation Strings and Keys feature to this library and resolves #69

With this update you can define translation keys at the root element of each locale, like this:

var messages = {
            'en': {
                'Welcome': 'Welcome to the site.'
            },
            'es': {
                'Hello': 'Hola',
            }
        };
        lang = new Lang({
            messages: messages
        });
        lang.setLocale('es');
        lang.setFallback('en');

This will produce the following outputs
lang.get('Welcome') ---> Welcome to the site
lang.get('Non existing') --> Non existing
lang.get('Hello') --> 'Hola`

@alwintom alwintom requested a review from rmariuzzo as a code owner May 4, 2020 05:46
@alwintom alwintom changed the base branch from master to develop May 4, 2020 05:50
@alwintom alwintom closed this May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Does it even work with JSON object messages?
5 participants