-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify the logic of switch and some names. #176
Merged
ye-luo-xi-tui
merged 10 commits into
rm-controls:double_barrel
from
NaHCO3bc:doubel-barrel-dev
Jul 24, 2023
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
f5e9f2f
Modify double barrel command sender.
Edwinlinks fa2af4c
Delete unused header.
Edwinlinks 7dba350
Fix some logic bug about switching barrel.
NaHCO3bc 2c544c2
Solve the bug that the frequency of shooter will not be set before th…
NaHCO3bc 12bd9af
Add setMode
NaHCO3bc 94ba2a1
Parameterize some thresholds.
NaHCO3bc 95c9e88
Move the switchBarrel function into sendcommand.
NaHCO3bc 6773ce0
Change the param name to is_switching and simplify the logic
NaHCO3bc 085a426
Add two duration judgements to optimize the logic.
NaHCO3bc 299d99e
Modify some names of params and add a frequency threshold
NaHCO3bc File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
应该一个参数就行了吧?为啥要两个
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
因为叶子哥说频率等于0的条件太苛刻了,要参数化
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
凯子意思是说你两个变量都读同一个参数,一个变量就够了
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
嘶那是我写错了,应该读的是不同的参数
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
所以是打算用同一个参数还是怎么样