Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Major changes for version 0.3.0 #9

Merged
merged 16 commits into from
Jan 22, 2024
Merged

Major changes for version 0.3.0 #9

merged 16 commits into from
Jan 22, 2024

Conversation

rly
Copy link
Owner

@rly rly commented Mar 1, 2023

Based on feedback from NWB TAB. See Google Doc: https://docs.google.com/document/d/1qcsjyFVX9oI_746RdMoDdmQPu940s0YtDjb1en1Xtdw/edit

  • Removed all data types Events, LabeledEvents, TTLs, and AnnotatedEvents.
  • Added new data types EventsTable, EventsTypesTable, TtlsTable, TtlTypesTable.
  • Added new data types TimestampVectorData and DurationVectorData.
  • Added new data type Task to hold an EventsTypesTable and TtlTypesTable.
  • Replaced setup.py with pyproject.toml
  • Use ruff and black for style
  • Updated version to 0.3.0
  • Moved and rewrote tests

TODO:

  • Update requirements to use HDMF 3.11.0 which includes bug fixes for auto-generated classes.

@rly rly changed the title Revamp LabeledEvents and add new table types Major changes for version 0.3.0 Oct 25, 2023
@rly rly marked this pull request as ready for review October 25, 2023 23:22
@rly rly merged commit eb7c974 into main Jan 22, 2024
1 check passed
@rly rly deleted the proposed_0.3.0 branch January 22, 2024 16:59
generateExtension('<directory path>/ndx-events/spec/ndx-events.namespace.yaml');
```
## Example usage

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rly where the examples moved somewhere else? I found them useful when using this extension.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that they were availble in this commit but they did not make it to the end of the PR:

0672b9a

Is this a mistake?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants