fix prompting in org-ai-refactor-code

rksm · Oct 20, 2024 · 5adfde1 · 5adfde1
1 parent c8977cf
commit 5adfde1
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 4 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,9 @@
 # Changelog
 
+## [0.5.4] - 2024-10-20
+### Changed
+- fix prompting in `org-ai-refactor-code`
+
 ## [0.5.3] - 2024-10-20
 ### Changed
 - fix progress reporter for non-streamed responses (fixes completion for o1 models)

diff --git a/org-ai-openai.el b/org-ai-openai.el
@@ -740,7 +740,8 @@ and the length in chars of the pre-change text replaced by that range."
                           (set-marker org-ai--url-buffer-last-position-marker (point)))
                       (error
                        (setq errored t)
-                       (goto-char org-ai--url-buffer-last-position-marker)))))))))))))
+                       (when org-ai--url-buffer-last-position-marker
+                         (goto-char org-ai--url-buffer-last-position-marker))))))))))))))
 
 (defun org-ai--stream-supported (service model)
   "Check if the stream is supported by the service and model.

diff --git a/org-ai-useful.el b/org-ai-useful.el
@@ -135,15 +135,17 @@ Will always return t if `org-ai-talk-confirm-speech-input' is nil."
     (let ((output-buffer (or output-buffer (current-buffer)))
           (start-pos-marker (point-marker)))
       (let* ((sys-input (if sys-prompt (format "[SYS]: %s\n" sys-prompt)))
-             (input (format "%s\n[ME]: %s" sys-input prompt)))
+             (input (format "%s\n[ME]: %s" sys-input prompt))
+             (callback-called nil))
         (with-current-buffer output-buffer
           (setq org-ai-prompt--last-insertion-marker (point-marker)))
         (org-ai-stream-request :messages (org-ai--collect-chat-messages input)
                                :model org-ai-default-chat-model
                                :callback (lambda (response)
                                            (when (cl-some (lambda (ea) (eq 'stop (org-ai--response-type ea)))
                                                           (org-ai--insert-stream-response nil output-buffer response nil))
-                                             (when callback
+                                             (when (and callback (not callback-called))
+                                               (setq callback-called t)
                                                (with-current-buffer
                                                    output-buffer (funcall callback))))))))))
 

diff --git a/org-ai.el b/org-ai.el
@@ -4,7 +4,7 @@
 
 ;; Author: Robert Krahn <[email protected]>
 ;; URL: https://github.com/rksm/org-ai
-;; Version: 0.5.3
+;; Version: 0.5.4
 ;; Package-Requires: ((emacs "27.1") (websocket "1.15"))
 
 ;; This file is NOT part of GNU Emacs.