forked from rodgomesc/vision-camera-code-scanner
-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support vision camera v4 #7
Open
ismaelsousa
wants to merge
39
commits into
rkmackinnon:master
Choose a base branch
from
ismaelsousa:v3
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes File Not Found errors importing VisionCamera public header files in the VisionCameraCodeScanner bridging header.
Register plugin outside of AppDelegate
Bump min deployment version to match VisionCamera dependency
Remove no longer necessary frame processor plugin registration in AppDelegate didFinishLaunchingWithOptions
…n-camera-v3_hook Fix hook & corresponding documentation
Seems to make a difference in whether exported scanBarcodes function is defined in the hook.
See: mrousavy/react-native-vision-camera#1754 for Android. We need this to be able to pass in the types array.
requires newer commits on react-native-vision-camera than v3.0.0 in npm
fixes an incompatibility with react-native-reanimated
I just realized there are several PRs here that I didn't notice, sorry! I guess GitHub forces you to explicitly "watch" your own repos to get these notifications? Anyways, it looks like you've created your own fork and published this to NPM already. I'm happy you were able to get this to work, and thanks for making the PR to let me know about it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support vision camera v4