Skip to content
This repository has been archived by the owner on Sep 17, 2024. It is now read-only.

feat(users): users profile pictures #77

Open
wants to merge 3 commits into
base: 03-29-feat_create_uploads_module
Choose a base branch
from
Open

feat(users): users profile pictures #77

wants to merge 3 commits into from

Conversation

Blckbrry-Pi
Copy link
Collaborator

@Blckbrry-Pi Blckbrry-Pi commented Apr 1, 2024 •
edited
Loading

Resolves OGB-20

@Blckbrry-Pi Graphite App
Copy link
Collaborator Author

Blckbrry-Pi commented Apr 1, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Blckbrry-Pi and the rest of your teammates on Graphite Graphite

@Blckbrry-Pi Blckbrry-Pi mentioned this pull request Apr 1, 2024
Merged
@linear Linear
Copy link

linear bot commented Apr 1, 2024

OGB-20 `users` profile pictures

@Blckbrry-Pi Blckbrry-Pi marked this pull request as ready for review April 1, 2024 00:50
@Blckbrry-Pi Blckbrry-Pi mentioned this pull request Apr 1, 2024
Closed
@Blckbrry-Pi Blckbrry-Pi force-pushed the 03-29-feat_create_uploads_module branch from bd5c746 to bc110e5 Compare April 1, 2024 18:13
@Blckbrry-Pi Blckbrry-Pi force-pushed the 03-31-feat_users_users_profile_pictures branch from 888d74b to 4495c1f Compare April 1, 2024 18:13
@Blckbrry-Pi Blckbrry-Pi force-pushed the 03-29-feat_create_uploads_module branch from bc110e5 to 1d39eaf Compare April 1, 2024 18:19
@Blckbrry-Pi Blckbrry-Pi force-pushed the 03-31-feat_users_users_profile_pictures branch from 4495c1f to 52b0244 Compare April 1, 2024 18:19
NathanFlurry
NathanFlurry suggested changes Apr 16, 2024
View reviewed changes
modules/users/config.ts Outdated Show resolved Hide resolved
modules/users/db/schema.prisma Outdated Show resolved Hide resolved
modules/users/scripts/set_pfp.ts Outdated Show resolved Hide resolved
modules/users/scripts/start_pfp_upload.ts Outdated Show resolved Hide resolved
modules/users/scripts/start_pfp_upload.ts Outdated Show resolved Hide resolved
modules/users/scripts/start_pfp_upload.ts Outdated Show resolved Hide resolved
modules/users/tests/pfp.ts Outdated Show resolved Hide resolved
modules/users/utils/pfp.ts Outdated Show resolved Hide resolved
modules/users/utils/types.ts Outdated Show resolved Hide resolved
tests/basic/backend.yaml Outdated Show resolved Hide resolved
@Blckbrry-Pi Blckbrry-Pi force-pushed the 03-29-feat_create_uploads_module branch 3 times, most recently from c26e522 to b751ee9 Compare April 17, 2024 16:23
@Blckbrry-Pi Blckbrry-Pi force-pushed the 03-31-feat_users_users_profile_pictures branch 3 times, most recently from 7adfa79 to 9ae331f Compare April 17, 2024 17:01
@Blckbrry-Pi Blckbrry-Pi force-pushed the 03-29-feat_create_uploads_module branch from b751ee9 to 9366389 Compare April 17, 2024 17:03
@Blckbrry-Pi Blckbrry-Pi force-pushed the 03-31-feat_users_users_profile_pictures branch from 9ae331f to 799c23c Compare April 17, 2024 17:05
NathanFlurry
NathanFlurry suggested changes Apr 17, 2024
View reviewed changes
Copy link
Member

@NathanFlurry NathanFlurry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getting closer, nice

modules/users/db/schema.prisma Outdated Show resolved Hide resolved
modules/users/db/schema.prisma Outdated Show resolved Hide resolved
modules/users/config.ts Outdated Show resolved Hide resolved
@Blckbrry-Pi Blckbrry-Pi force-pushed the 03-31-feat_users_users_profile_pictures branch from 799c23c to 530a5e9 Compare April 18, 2024 11:10
@Blckbrry-Pi Blckbrry-Pi force-pushed the 03-29-feat_create_uploads_module branch from 9366389 to 2efca85 Compare April 19, 2024 13:44
@Blckbrry-Pi Blckbrry-Pi force-pushed the 03-31-feat_users_users_profile_pictures branch 2 times, most recently from 852f02a to 38a1e0d Compare April 19, 2024 13:50
@Blckbrry-Pi Blckbrry-Pi force-pushed the 03-29-feat_create_uploads_module branch 4 times, most recently from 9e8c3b8 to d9f0c5b Compare May 22, 2024 00:01
@Blckbrry-Pi Blckbrry-Pi force-pushed the 03-31-feat_users_users_profile_pictures branch 3 times, most recently from 43d7a67 to 92aa757 Compare May 22, 2024 00:54
@Blckbrry-Pi Blckbrry-Pi force-pushed the 03-29-feat_create_uploads_module branch from d9f0c5b to 3c40379 Compare May 29, 2024 17:21
NathanFlurry
NathanFlurry suggested changes Jun 4, 2024
View reviewed changes
modules/users/scripts/prepare_profile_picture.ts
}

// Prepare the upload to get the presigned URL
const { upload: presigned } = await ctx.modules.uploads.prepare({
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs a tag: { users: { kind: "profile_picture", userId: "xxxx" } }

modules/users/db/schema.prisma
createdAt DateTime @default(now())
updatedAt DateTime @updatedAt

avatarUploadId String? @db.Uuid
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

profilePictureUploadId

modules/users/module.yaml Outdated
public: true
prepare_profile_picture:
name: Start Profile Picture Upload
description: Allow the user to begin uploading a profile picture.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add comment about complete with set_profile_picture

modules/users/module.yaml Outdated
@@ -24,8 +26,22 @@ scripts:
create_user_token:
name: Create User Token
description: Create a token for a user to authenticate future requests.
set_profile_picture:
name: Set Profile Picture
description: Set the profile picture for a user.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add comment about prepare with prepare_profile_picture

@NathanFlurry NathanFlurry force-pushed the 03-29-feat_create_uploads_module branch from 3c40379 to cb8c42d Compare June 7, 2024 23:38
@NathanFlurry NathanFlurry force-pushed the 03-31-feat_users_users_profile_pictures branch from 92aa757 to 446ff6d Compare June 7, 2024 23:39
@NathanFlurry NathanFlurry force-pushed the 03-29-feat_create_uploads_module branch 3 times, most recently from 1db2dcd to 2c11c57 Compare June 10, 2024 04:13
@NathanFlurry NathanFlurry force-pushed the 03-31-feat_users_users_profile_pictures branch from 446ff6d to 60656cd Compare June 10, 2024 04:13
@NathanFlurry NathanFlurry mentioned this pull request Jun 10, 2024
Merged
@NathanFlurry NathanFlurry force-pushed the 03-29-feat_create_uploads_module branch from 2c11c57 to 875a790 Compare June 10, 2024 04:36
@NathanFlurry NathanFlurry force-pushed the 03-31-feat_users_users_profile_pictures branch from 60656cd to 2f7639a Compare June 10, 2024 04:36
@NathanFlurry NathanFlurry force-pushed the 03-29-feat_create_uploads_module branch from 875a790 to 8cb913b Compare June 10, 2024 04:38
@NathanFlurry NathanFlurry force-pushed the 03-31-feat_users_users_profile_pictures branch from 2f7639a to fa4f889 Compare June 10, 2024 04:38
@NathanFlurry NathanFlurry force-pushed the 03-29-feat_create_uploads_module branch from 8cb913b to 8173f65 Compare June 10, 2024 05:32
@NathanFlurry NathanFlurry force-pushed the 03-31-feat_users_users_profile_pictures branch from fa4f889 to d7a5892 Compare June 10, 2024 05:32
@NathanFlurry NathanFlurry force-pushed the 03-29-feat_create_uploads_module branch from 8173f65 to 34ef6be Compare June 10, 2024 05:33
@NathanFlurry NathanFlurry force-pushed the 03-31-feat_users_users_profile_pictures branch from d7a5892 to dc9024c Compare June 10, 2024 05:33
@NathanFlurry NathanFlurry force-pushed the 03-29-feat_create_uploads_module branch from 34ef6be to b2312b2 Compare June 10, 2024 05:34
@NathanFlurry NathanFlurry force-pushed the 03-31-feat_users_users_profile_pictures branch from dc9024c to 4c28f2b Compare June 10, 2024 05:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@NathanFlurry NathanFlurry NathanFlurry requested changes

@MasterPtato MasterPtato MasterPtato approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Blckbrry-Pi @NathanFlurry @MasterPtato