This repository has been archived by the owner on Sep 17, 2024. It is now read-only.
feat: Link the auth_email module to the auth_providers module
#125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 1, 2024
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @Blckbrry-Pi and the rest of your teammates on |
Blckbrry-Pi
force-pushed
the
07-01-feat_link_the_auth_oauth2_module_to_the_auth_provider_module
branch
from
0cb2af2
to
2599c2e
Compare
Blckbrry-Pi
force-pushed
the
07-01-feat_link_the_auth_email_module_to_the_auth_providers_module
branch
from
64b59a3
to
71092e8
Compare
Blckbrry-Pi
force-pushed
the
07-01-feat_link_the_auth_email_module_to_the_auth_providers_module
branch
from
71092e8
to
3248b45
Compare
Blckbrry-Pi
changed the base branch from
07-01-feat_link_the_auth_oauth2_module_to_the_auth_provider_module
to
05-10-feat_create_an_oauth2_module_for_authenticating_users
Blckbrry-Pi
force-pushed
the
05-10-feat_create_an_oauth2_module_for_authenticating_users
branch
from
296d866
to
c0dc3ef
Compare
Blckbrry-Pi
force-pushed
the
07-01-feat_link_the_auth_email_module_to_the_auth_providers_module
branch
from
3248b45
to
fb1643f
Compare
Blckbrry-Pi
force-pushed
the
05-10-feat_create_an_oauth2_module_for_authenticating_users
branch
from
c0dc3ef
to
fb94688
Compare
Blckbrry-Pi
force-pushed
the
07-01-feat_link_the_auth_email_module_to_the_auth_providers_module
branch
from
fb1643f
to
bad4814
Compare
Blckbrry-Pi
force-pushed
the
05-10-feat_create_an_oauth2_module_for_authenticating_users
branch
2 times, most recently
from
1cace66
to
8227c7e
Compare
Blckbrry-Pi
force-pushed
the
07-01-feat_link_the_auth_email_module_to_the_auth_providers_module
branch
from
bad4814
to
bae99d7
Compare
Blckbrry-Pi
force-pushed
the
05-10-feat_create_an_oauth2_module_for_authenticating_users
branch
from
8227c7e
to
78ce41b
Compare
Blckbrry-Pi
force-pushed
the
07-01-feat_link_the_auth_email_module_to_the_auth_providers_module
branch
2 times, most recently
from
18d6582
to
1a763f4
Compare
Blckbrry-Pi
changed the base branch from
05-10-feat_create_an_oauth2_module_for_authenticating_users
to
07-04-feat_create_the_user_passwords_module
Blckbrry-Pi
force-pushed
the
07-04-feat_create_the_user_passwords_module
branch
from
a603a06
to
cc6b5aa
Compare
Blckbrry-Pi
force-pushed
the
07-01-feat_link_the_auth_email_module_to_the_auth_providers_module
branch
from
1a763f4
to
ce75d1f
Compare
Blckbrry-Pi
force-pushed
the
07-04-feat_create_the_user_passwords_module
branch
from
cc6b5aa
to
7a771d2
Compare
Blckbrry-Pi
force-pushed
the
07-01-feat_link_the_auth_email_module_to_the_auth_providers_module
branch
from
ce75d1f
to
e6212d6
Compare
Blckbrry-Pi
force-pushed
the
07-04-feat_create_the_user_passwords_module
branch
from
7a771d2
to
a84215f
Compare
Blckbrry-Pi
force-pushed
the
07-01-feat_link_the_auth_email_module_to_the_auth_providers_module
branch
from
e6212d6
to
dab700c
Compare
Blckbrry-Pi
force-pushed
the
07-01-feat_link_the_auth_email_module_to_the_auth_providers_module
branch
from
dab700c
to
e783f99
Compare
NathanFlurry
suggested changes
Aug 2, 2024
| "user_passwords": {}, | ||
| "rate_limit": {} | ||
| }, | ||
| "scripts": { |
There was a problem hiding this comment.
this api is suuuper confusing (i know i helped design it :P). thoughts on splitting this up in to two modules which expose public scripts that call internal scripts exposed in this module. so devs will call auth_email_password and auth_email_passwordless.
There was a problem hiding this comment.
Will do eventually. Soon™.
| } | ||
| } | ||
|
|
||
| export async function ensureNotAssociatedAll( |
There was a problem hiding this comment.
this is very very expensive, it does at least 3 round trips to the database before doing anything else in the request. we should expose a batch api on identities module for this.
There was a problem hiding this comment.
Will do. I'm wondering if we should be able to select matching identities by identityType, as this may be useful for other things in the future.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.