fix: change Sentry configuration and changelog crash (#371)

rivet-gg · Sep 27, 2024 · a6ced3c · a6ced3c
1 parent db03f46
commit a6ced3c
Show file tree

Hide file tree

Showing 5 changed files with 32 additions and 21 deletions.
diff --git a/apps/hub/src/components/error-component.tsx b/apps/hub/src/components/error-component.tsx
@@ -10,8 +10,10 @@ import {
   Text,
 } from "@rivet-gg/components";
 import { Icon, faBomb } from "@rivet-gg/icons";
+import * as Sentry from "@sentry/react";
 import { useQueryClient } from "@tanstack/react-query";
 import type { ErrorComponentProps } from "@tanstack/react-router";
+import { useEffect } from "react";
 import { NotFoundComponent } from "./not-found-component";
 
 export const ErrorComponent = ({
@@ -20,6 +22,12 @@ export const ErrorComponent = ({
 }: Partial<ErrorComponentProps>) => {
   const queryClient = useQueryClient();
 
+  useEffect(() => {
+    if (error) {
+      Sentry.captureException(error);
+    }
+  }, [error]);
+
   if (isRivetError(error)) {
     if (error.statusCode === 404) {
       return <NotFoundComponent />;

diff --git a/apps/hub/src/components/header/changelog.tsx b/apps/hub/src/components/header/changelog.tsx
@@ -39,7 +39,7 @@ export function ChangelogEntry({
       <div>
         <img
           src={`https://rivet.gg/${images[0].url}`}
-          alt={images[0].alt}
+          alt={"Changelog entry"}
           className="rounded-md border my-4 h-[200px] object-cover w-full"
         />
 
@@ -95,29 +95,35 @@ export function Changelog() {
   );
 
   const hasNewChangelog = !lastChangelog
-    ? true
+    ? data.length > 0
     : data.some((entry) => new Date(entry.published) > new Date(lastChangelog));
 
+  const trigger = (
+    <NavItem
+      asChild
+      className="hidden md:inline-block relative py-3 data-open:text-foreground"
+    >
+      <a href="https://rivet.gg/changelog" target="_blank" rel="noreferrer">
+        {hasNewChangelog ? (
+          <span className="absolute top-2 -right-1.5 size-1.5 rounded-full bg-primary animate-pulse" />
+        ) : null}
+        Changelog
+      </a>
+    </NavItem>
+  );
+
+  if (data.length === 0) {
+    return trigger;
+  }
+
   return (
     <WithTooltip
       onOpenChange={(isOpen) => {
         if (isOpen) {
           setLast(data[0].published);
         }
       }}
-      trigger={
-        <NavItem
-          asChild
-          className="hidden md:inline-block relative py-3 data-open:text-foreground"
-        >
-          <a href="https://rivet.gg/changelog" target="_blank" rel="noreferrer">
-            {hasNewChangelog ? (
-              <span className="absolute top-2 -right-1.5 size-1.5 rounded-full bg-primary animate-pulse" />
-            ) : null}
-            Changelog
-          </a>
-        </NavItem>
-      }
+      trigger={trigger}
       content={<ChangelogEntry {...data[0]} />}
     />
   );

diff --git a/apps/hub/src/domains/user/queries/query-options.ts b/apps/hub/src/domains/user/queries/query-options.ts
@@ -39,7 +39,7 @@ export const selfProfileIdentityIdQueryOptions = () => {
 
 export const changelogQueryOptions = () => {
   return queryOptions({
-    queryKey: ["changelog"],
+    queryKey: ["changelog", __APP_GIT_COMMIT__],
     staleTime: timing.hours(1),
     queryFn: async () => {
       const response = await fetch("https://rivet.gg/changelog.json");

diff --git a/apps/hub/src/domains/user/queries/type.ts b/apps/hub/src/domains/user/queries/type.ts
@@ -1,9 +1,8 @@
 import { z } from "zod";
 
 export const ChangelogItem = z.object({
-  id: z.string(),
   published: z.string(),
-  images: z.array(z.object({ url: z.string(), alt: z.string() })),
+  images: z.array(z.object({ url: z.string() })),
   title: z.string(),
   description: z.string(),
   slug: z.string(),

diff --git a/apps/hub/vite.config.ts b/apps/hub/vite.config.ts
@@ -31,9 +31,7 @@ export default defineConfig({
           org: "rivet-gaming",
           project: "hub",
           authToken: process.env.SENTRY_AUTH_TOKEN,
-          release: {
-            name: `${GIT_BRANCH}@${GIT_SHA}`,
-          },
+          release: GIT_BRANCH === "main" ? { name: GIT_SHA } : undefined,
         })
       : null,
   ],