Optimize stream metadata service by skipping validation

river-build · Oct 22, 2024 · cc9d194 · cc9d194
1 parent e3e1c90
commit cc9d194
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/packages/encryption/src/decryptionExtensions.ts b/packages/encryption/src/decryptionExtensions.ts
@@ -691,7 +691,7 @@ export abstract class BaseDecryptionExtensions {
 
         const { isValid, reason } = this.isValidEvent(streamId, item.solicitation.srcEventId)
         if (!isValid) {
-            this.log.error('processing key solicitation: invalid event id', {
+            this.log.debug('processing key solicitation: invalid event id', {
                 streamId,
                 eventId: item.solicitation.srcEventId,
                 reason,

diff --git a/packages/stream-metadata/src/riverStreamRpcClient.ts b/packages/stream-metadata/src/riverStreamRpcClient.ts
@@ -17,6 +17,11 @@ import { FastifyBaseLogger } from 'fastify'
 import { MediaContent, StreamIdHex } from './types'
 import { getNodeForStream } from './streamRegistry'
 
+const STREAM_METADATA_SERVICE_DEFAULT_UNPACK_OPTS: UnpackEnvelopeOpts = {
+	disableHashValidation: true,
+	disableSignatureValidation: true,
+}
+
 const clients = new Map<string, StreamRpcClient>()
 
 export type StreamRpcClient = PromiseClient<typeof StreamService> & { url?: string }
@@ -180,7 +185,10 @@ export async function getStream(
 			'getStream finished',
 		)
 
-		const unpackedResponse = await unpackStream(response.stream, opts)
+		const unpackedResponse = await unpackStream(
+			response.stream,
+			opts ?? STREAM_METADATA_SERVICE_DEFAULT_UNPACK_OPTS,
+		)
 		return streamViewFromUnpackedResponse(streamId, unpackedResponse)
 	} catch (e) {
 		logger.error(