Fix: await file init in useRiveFile to catch async errors #270
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@damzobridge @bodymovin
When testing out #269, I realized that the errors thrown by
file.init()
were not actually being caught by the try/catch due toinit
being async.In the
rive-wasm
repo, in order to catch the errors thrown within the async init of the file, they useawait
(https://github.com/rive-app/rive-wasm/blob/6d5cd8909a635184f156be03d1f32d5ceb4025fc/js/src/rive.ts#L1739).Testing locally, this fixes my issue!
Before:
The app still crashes if I pass a bad
src
touseRiveFile
.After:
If there's a bad
src
, the app does not crash anymore. If thesrc
is valid, the Rive file loads and the animation plays as expected.