Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a react-canvas-lite package to build setup #214

Merged
merged 2 commits into from
Nov 8, 2023
Merged

Adding a react-canvas-lite package to build setup #214

merged 2 commits into from
Nov 8, 2023

Conversation

zplata
Copy link
Contributor

@zplata zplata commented Nov 8, 2023

Building on the new @rive-app/canvas-lite package, we should add a complimentary package that uses this new dependency for React in a new @rive-app/react-canvas-lite.

Added a Rive Text example to Storybook examples to test rivs should still render (without Rive Text)

@zplata zplata requested a review from HayesGordon November 8, 2023 05:15
@@ -165,6 +165,29 @@ Unlike the boolean and number inputs, you invoke the `.fire()` method on a trigg
</Story>
</Canvas>

## Rive Text
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this will not render anything?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will still render the graphic (all of the shapes/animated content without Rive text)

Copy link
Contributor

@HayesGordon HayesGordon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just left some comments about the example

@zplata zplata merged commit 83ebd67 into main Nov 8, 2023
1 check passed
@zplata zplata deleted the test-lite branch November 8, 2023 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants