Don't use GL_PIXEL_UNPACK_BUFFER

The ARM OpenGL driver appears to have a synchronization issue that presents in Unity when updating a texture via GL_PIXEL_UNPACK_BUFFER. (Calling glFinish() after glTexSubImage2D fixes it.) Furthermore, this isn't the first driver bug we've ran into with GL_PIXEL_UNPACK_BUFFER, as we already had a workaround in place for emscripten. Just don't use it. The perf gain was questionable anyway, especially in WebGL, which doesn't support buffer mapping. Diffs= 7c3c8a3a1a Don't use GL_PIXEL_UNPACK_BUFFER (#8708)
rive-app · Dec 7, 2024 · 5d33ff6 · 5d33ff6
1 parent efe0c9c
commit 5d33ff6
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/.rive_head b/.rive_head
@@ -1 +1 @@
-5df5be19407d970646e7a2192b0f6f0790d91096
+7c3c8a3a1a8b0c451b2ab2071e95dbfabe81dec6
diff --git a/submodules/rive-runtime b/submodules/rive-runtime
Original file line number	Diff line number	Diff line change
		@@ -1 +1 @@
		5df5be19407d970646e7a2192b0f6f0790d91096
		7c3c8a3a1a8b0c451b2ab2071e95dbfabe81dec6
+1 −1		.rive_head
+0 −1		renderer/include/rive/renderer/gl/gl_state.hpp
+1 −12		renderer/src/gl/gl_state.cpp
+19 −65		renderer/src/gl/render_context_gl_impl.cpp