-
Notifications
You must be signed in to change notification settings - Fork 31
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Build Cleanup & Dependency Minimization
[Additional Slack context](https://2dimensions.slack.com/archives/C03GXT15JKX/p1733267916478549). After our discussions around `androidx.core:core-ktx`, I did some investigations and it turns out we don't need it at all at the library level. This allows users to use any version they want, without impacting their `targetSdk`. This lead me down the path of wondering what other dependencies aren't necessary. So one by one I disabled them checking if it would break the build. In a couple instances I was able to go from a "bundle" dependency to only the exact sub-dependency required, e.g. `"androidx.test:core-ktx:1.6.1"` -> `androidx.test:runner`. There's also a bit of other minor housekeeping as I was poking around in these files. Diffs= b90fd3019f Build Cleanup & Dependency Minimization (#8675) Co-authored-by: Erik <[email protected]>
- Loading branch information
1 parent
837241c
commit 4f70fd7
Showing
15 changed files
with
35 additions
and
160 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
9dfd01fb3a8853f666ffc0c02ed6869668a35432 | ||
b90fd3019f6c9d1f1692f2af60f6d762cac58aba |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16 changes: 0 additions & 16 deletions
16
app/src/test/java/app/rive/runtime/example/ExampleUnitTest.kt
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
22 changes: 0 additions & 22 deletions
22
...tytest/src/androidTest/java/app/rive/runtime/compatibilitytest/ExampleInstrumentedTest.kt
This file was deleted.
Oops, something went wrong.
16 changes: 0 additions & 16 deletions
16
compatibilitytest/src/test/java/app/rive/runtime/compatibilitytest/ExampleUnitTest.kt
This file was deleted.
Oops, something went wrong.
Binary file not shown.
Binary file not shown.
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16 changes: 0 additions & 16 deletions
16
kotlin/src/test/java/app/rive/runtime/kotlin/ExampleUnitTest.kt
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,5 @@ | ||
rootProject.name = "rive-android" | ||
|
||
include ':kotlin' | ||
include ':app' | ||
rootProject.name = "rive-android" | ||
include ':compatibilitytest' |