Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add handling aaguid and authenticator name #12

Merged
merged 5 commits into from
Sep 27, 2023
Merged

Conversation

ritou
Copy link
Owner

@ritou ritou commented Sep 27, 2023

The library has not previously handled aaguid, but this PR adds logic to identify the Authenticator Name using Passkey and MDS aaguid data.

@ritou ritou self-assigned this Sep 27, 2023
@ritou ritou merged commit cd89d2e into master Sep 27, 2023
10 checks passed
@ritou
Copy link
Owner Author

ritou commented Sep 27, 2023

Chrome on Mac: OK

スクリーンショット 2023-09-28 2 34 21

Safari on Mac: Empty

スクリーンショット 2023-09-28 2 35 47

Passkey on Android: OK

スクリーンショット 2023-09-28 2 38 48

1Password: OK

スクリーンショット 2023-09-28 2 40 39

Hybrid Transports w/ Android: OK

スクリーンショット 2023-09-28 2 45 35

@ritou
Copy link
Owner Author

ritou commented Sep 27, 2023

Yubikey: Empty

スクリーンショット 2023-09-28 3 09 57

Chromebook: Unknown?

スクリーンショット 2023-09-28 3 13 13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant