Add hypervisor support for PrivRw #540
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@aswaterman Would you kindly take a look? |
aswaterman
reviewed
Nov 12, 2024
There was a problem hiding this comment.
I'm not familiar with this code, so I'd rather @aap-sc, @en-sc, or @timsifive sign off on this.
en-sc
reviewed
Nov 12, 2024
Comment on lines
+1652
to
+1653
| # It may be affected by reset halt | ||
| misa = self.gdb.p(f"$misa=0x{self.hart.misa:x}") |
There was a problem hiding this comment.
I don't quite get it. Which part is responsible for setting misa.H?
There was a problem hiding this comment.
When the power is turned on, the hart starts executing the brom code. Here does not affect this case, repeated testing will affect CheckMisa.
debug/gdbserver.py
Outdated
Comment on lines
1660
to
1661
| self.supported.add(4) | ||
| self.supported.add(5) |
There was a problem hiding this comment.
AFAIU, H extension does not require presence of both S and U extensions.
Therefore, I'd suggest something like:
Suggested change
| self.supported.add(4) | |
| self.supported.add(5) | |
| self.supported_vmodes = self.supported | |
| else: | |
| self.supported_vmodes = None |
lz-bro
force-pushed
the
priv_add_v
branch
5 times, most recently
from
c2340c6
to
dffe978
Compare
Change-Id: I635a8f86b407f104ea74f00f4aefa1ce8170cb2d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-Id: I635a8f86b407f104ea74f00f4aefa1ce8170cb2d