target/riscv: merged read/write functions to one access function #1194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@JanMatCodasip, @MarekVCodasip could you please take a look? |
en-sc
approved these changes
Dec 26, 2024
src/target/riscv/riscv-013.c
Outdated
Comment on lines
4377
to
4379
| if (mstatus != mstatus_old && register_write_direct(target, | ||
| GDB_REGNO_MSTATUS, mstatus_old) != ERROR_OK) | ||
| return MEM_ACCESS_SKIPPED_REG_WRITE_FAILED; |
fk-sc
force-pushed
the
fk-sc/merge-read-write
branch
2 times, most recently
from
02d8718 to
a1686db
Compare
en-sc
requested changes
Dec 27, 2024
fk-sc
force-pushed
the
fk-sc/merge-read-write
branch
from
a1686db to
25e187e
Compare
en-sc
requested changes
Dec 28, 2024
Commit merges read/write functions to access function. It allows to decrease amount of code duplication. Signed-off-by: Farid Khaydari <[email protected]>
fk-sc
force-pushed
the
fk-sc/merge-read-write
branch
from
25e187e to
fd6fd98
Compare
en-sc
approved these changes
Dec 28, 2024
|
|
||
| if (args.count == 0) | ||
| return ERROR_OK; | ||
| mem_access_result_t res = mem_should_skip_abstract(target, args); |
There was a problem hiding this comment.
Suggested change
| mem_access_result_t res = mem_should_skip_abstract(target, args); | |
| mem_access_result_t skip_reason = mem_should_skip_abstract(target, args); |
I would prefer if this kept it's old name.
MarekVCodasip
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit merges
read/writefunctions toaccessfunction. It allows to decrease amount of code duplication